zheliu2 commented on code in PR #15530:
URL: https://github.com/apache/iceberg/pull/15530#discussion_r2906672285
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -176,7 +176,7 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
// If we got an AWS exception we would usually handle, but find we
// succeeded on a retry that threw an exception, skip the exception.
- if (commitStatus != CommitStatus.SUCCESS && isAwsServiceException) {
+ if (commitStatus == CommitStatus.FAILURE && persistFailure instanceof
AwsServiceException) {
Review Comment:
It looks like this change from `!= SUCCESS` to `== FAILURE` might also fix a
subtle secondary issue — when `commitStatus` is `UNKNOWN` with an
`AwsServiceException`, the old condition would route it into
`handleAWSExceptions`, which throws `CommitFailedException`. I wonder if
`UNKNOWN` should instead fall through to the switch and throw
`CommitStateUnknownException`? The new condition seems to handle this
correctly, but want to raise it up and see if this is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
