rdblue commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2897557332
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -124,12 +124,12 @@ private String metadataFileLocation(Table table) {
}
}
- private FileIO fileIO(Table table) {
- if (table.io() instanceof HadoopConfigurable) {
- ((HadoopConfigurable)
table.io()).serializeConfWith(SerializableConfSupplier::new);
+ public static FileIO copyOf(FileIO fileIO) {
Review Comment:
It doesn't make sense to me that a public static method with this behavior
would be here or would be named `copyOf` within `SerializableTable`. I
understand not wanting to make many changes, but this introduces odd behavior
and we should always consider the API surface area that changes produce.
This should be a util method specific to `FileIO` and should not be here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
