RussellSpitzer commented on code in PR #15239:
URL: https://github.com/apache/iceberg/pull/15239#discussion_r2897305213
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -95,8 +96,9 @@ public class SparkMicroBatchStream implements
MicroBatchStream, SupportsTriggerA
this.maxRecordsPerMicroBatch = readConf.maxRecordsPerMicroBatch();
this.cacheDeleteFilesOnExecutors = readConf.cacheDeleteFilesOnExecutors();
Review Comment:
Kind of a nit but we can be a little cleaner in intent now:
Initial Offset only really needs HadoopConfiguration now so we may as well
make the HadoopFileIO there, also lets us change this later if we really want
to use HadoopFS
So basically InitialOffsetStore(table, checkpointLocation, fromTimestamp,
Configuration)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
