steveloughran commented on PR #15428: URL: https://github.com/apache/iceberg/pull/15428#issuecomment-4012759866
@adutra @danielcweeks I've gone back to the servlet-only decision about what to sign, but with an expanded set of headers: more SDK, more "aws-" service and some of the classic http protocol fluff. That's all I care about, as it's enough to reduce the risk that slightly different GET requests will match in the cache but be inconsistently signed. Alex's tests in TestS3V4RestSignerClient are retained, as are my ones in TestS3RestSigner, which expands validation of multipart upload completion and a few more opeations. It doesn't make any assertions on cache hit/miss though, due to the roll-back of `S3V4RestSignerClient`, instead it is just making sure that the operations work at all. I'm personally happy with just the expanded set of stripped headers, which this iteration provides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
