RussellSpitzer commented on code in PR #15514:
URL: https://github.com/apache/iceberg/pull/15514#discussion_r2896470237
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -738,6 +741,78 @@ public void testEqualityDeleteWithSchemaEvolution() throws
IOException {
assertThat(actual).hasSize(expectedRecordCount);
}
+ /**
+ * Covers a bug where equality deletes columns are appended to the required
schema in a different
+ * order than the table schema, which can cause different deleteSchema
orderings, poisoning the
+ * cache.
+ */
+ @TestTemplate
+ public void testEqualityDeletesAppliedWithCachedFieldReordering() throws
IOException {
+ Schema eqDeleteTestSchema =
+ new Schema(
+ Types.NestedField.optional(1, "id", Types.IntegerType.get()),
+ Types.NestedField.optional(2, "a", Types.IntegerType.get()),
+ Types.NestedField.optional(3, "b", Types.IntegerType.get()));
+ PartitionSpec spec =
PartitionSpec.builderFor(eqDeleteTestSchema).bucket("id", 1).build();
Review Comment:
No reason, I originally had this in a different file where all the tables
were partitioned and I didn't want to feel left out. Now that it's here we can
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
