mbutrovich commented on code in PR #2176:
URL: https://github.com/apache/iceberg-rust/pull/2176#discussion_r2896003278
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -490,19 +501,17 @@ impl ArrowReader {
Ok(Box::pin(record_batch_stream) as ArrowRecordBatchStream)
}
- pub(crate) async fn create_parquet_record_batch_stream_builder(
+ /// Loads Parquet metadata from storage, handling file size optimization.
+ pub(crate) async fn load_parquet_metadata(
data_file_path: &str,
- file_io: FileIO,
+ file_io: &FileIO,
should_load_page_index: bool,
- arrow_reader_options: Option<ArrowReaderOptions>,
Review Comment:
Thanks for the review @jdockerty! `ArrowReaderOptions` should be required
now instead of an `Option`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
