nastra commented on PR #15171: URL: https://github.com/apache/iceberg/pull/15171#issuecomment-4011729378
@adutra isn't the issue described in https://github.com/apache/iceberg/issues/15166 that the server sent back `cache-control: private` for a `PUT` request? By default, the server should really only be caching `GET` and `HEAD` requests. I don't think we called this out anywhere (and you mentioned it in https://github.com/apache/iceberg/pull/15171#issuecomment-4005586102) but the reference implementation in https://github.com/apache/iceberg/blob/db34c1c18b20b389c64a449f21c2296f2f25402a/aws/src/integration/java/org/apache/iceberg/aws/s3/signer/S3SignerServlet.java#L78-L79 works based on that behavior. I also agree with the points that @danielcweeks brought up, since the catalog should be in full control over what requests are actually safe to cache and which are not. Ultimately, remote signing is a catalog concern and clients shouldn't have control over what to sign. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
