nastra commented on code in PR #15515:
URL: https://github.com/apache/iceberg/pull/15515#discussion_r2894503114
##########
baseline.gradle:
##########
@@ -57,9 +56,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/testFixtures/java/**/*.java', 'src/jmh/java/**/*.java',
'src/integration/java/**/*.java'
- // 1.23.0 has an issue in formatting comments
https://github.com/google/google-java-format/issues/1155
- // so we stick to 1.22.0 to produce consistent result for JDK 17/21
- googleJavaFormat("1.22.0")
+ googleJavaFormat("1.25.2")
Review Comment:
we should be able to upgrade to 1.28.0 but I would suggest to do this in a
separate PR. In that PR you can also include the version bump for the spotless
plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
