blackmwk commented on code in PR #2214: URL: https://github.com/apache/iceberg-rust/pull/2214#discussion_r2893393166
########## crates/iceberg/src/io/file_io.rs: ########## @@ -39,12 +39,12 @@ use crate::Result; /// /// | Storage | Feature Flag | Expected Path Format | Schemes | /// |--------------------|-------------------|----------------------------------| ------------------------------| -/// | Local file system | `storage-fs` | `file` | `file://path/to/file` | -/// | Memory | `storage-memory` | `memory` | `memory://path/to/file` | -/// | S3 | `storage-s3` | `s3`, `s3a` | `s3://<bucket>/path/to/file` | -/// | GCS | `storage-gcs` | `gs`, `gcs` | `gs://<bucket>/path/to/file` | -/// | OSS | `storage-oss` | `oss` | `oss://<bucket>/path/to/file` | -/// | Azure Datalake | `storage-azdls` | `abfs`, `abfss`, `wasb`, `wasbs` | `abfs://<filesystem>@<account>.dfs.core.windows.net/path/to/file` or `wasb://<container>@<account>.blob.core.windows.net/path/to/file` | +/// | Local file system | `opendal-fs` | `file` | `file://path/to/file` | +/// | Memory | `opendal-memory` | `memory` | `memory://path/to/file` | +/// | S3 | `opendal-s3` | `s3`, `s3a` | `s3://<bucket>/path/to/file` | +/// | GCS | `opendal-gcs` | `gs`, `gcs` | `gs://<bucket>/path/to/file` | +/// | OSS | `opendal-oss` | `oss` | `oss://<bucket>/path/to/file` | +/// | Azure Datalake | `opendal-azdls` | `abfs`, `abfss`, `wasb`, `wasbs` | `abfs://<filesystem>@<account>.dfs.core.windows.net/path/to/file` or `wasb://<container>@<account>.blob.core.windows.net/path/to/file` | Review Comment: We should remove this. This crate now only supports memory and fs. We should also update README.md to point user to use `iceberg-storage-opendal` if they need more fs support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
