danielcweeks commented on code in PR #15450:
URL: https://github.com/apache/iceberg/pull/15450#discussion_r2886374186
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4693,6 +4729,62 @@ components:
allOf:
- $ref: '#/components/schemas/Expression'
+ MultiValuedMap:
+ description: A map of string keys where each key can map to multiple
string values.
+ type: object
+ additionalProperties:
+ type: array
+ items:
+ type: string
+
+ RemoteSignRequest:
+ description: The request to be signed remotely.
+ type: object
+ required:
+ - region
+ - uri
+ - method
+ - headers
+ properties:
+ region:
+ type: string
+ uri:
+ type: string
+ method:
+ type: string
+ enum: ["PUT", "GET", "HEAD", "POST", "DELETE", "PATCH", "OPTIONS"]
+ headers:
+ $ref: '#/components/schemas/MultiValuedMap'
+ properties:
+ type: object
+ additionalProperties:
+ type: string
+ body:
+ type: string
+ description: Optional body of the request to send to the signing
API. This should only be populated
+ for requests where the body of the message contains content which
must be validated before a request is
+ signed, such as the S3 DeleteObjects call.
+ provider:
+ type: string
+ enum:
Review Comment:
I'm concerned the enumeration here is too strict and should be left as just
a string value. We're blocking out other provides that support `HMAC-SHA256`
or similar signing.
We shouldn't bake explicit cloud or vendor products into the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
