zhjwpku commented on code in PR #570:
URL: https://github.com/apache/iceberg-cpp/pull/570#discussion_r2837026260
##########
src/iceberg/util/decimal.cc:
##########
@@ -56,7 +56,7 @@ constexpr Decimal kMaxDecimalValue(5421010862427522170LL,
687399551400673279ULL)
constexpr Decimal kMinDecimalValue(-5421010862427522171LL,
17759344522308878337ULL);
struct DecimalComponents {
- std::string_view while_digits;
+ std::string_view whole_digits;
Review Comment:
Yes, that was an oversight while copying from Arrow's code[1].
[1]
https://github.com/apache/arrow/blob/8c27898d36f45ece9b0d114b3d6c6a42d20bde7f/cpp/src/arrow/util/decimal.cc#L793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
