alexandre-normand commented on code in PR #721:
URL: https://github.com/apache/iceberg-go/pull/721#discussion_r2834651319
##########
manifest.go:
##########
@@ -1136,7 +1136,7 @@ func (w *ManifestWriter) Close() error {
return w.writer.Close()
}
-func (w *ManifestWriter) ToManifestFile(location string, length int64)
(ManifestFile, error) {
+func (w *ManifestWriter) ToManifestFile(location string, length int64, content
ManifestContent) (ManifestFile, error) {
Review Comment:
👍 I can make a new vararg parameter to take in options and have a
`WithContent` option to override the `content` to keep backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
