kumarpritam863 commented on PR #15345:
URL: https://github.com/apache/iceberg/pull/15345#issuecomment-3928222495
So two things here:
1. Even if the schema is disabled, the types is inferred by the value: If
value was of type java.util.Date then this part should have returned
TimestampType `else if (value instanceof java.util.Date || value instanceof
OffsetDateTime) {
return TimestampType.withZone();` and if the value was not a type of
java.util.Date then you would not receive error.
> The fix also makes convertLong() consistent with convertDateValue(),
convertTimeValue(), convertOffsetDateTime(), and convertLocalDateTime(), which
all already handle java.util.Date using the same
The other methods has a handling for date because their name suggests so, in
case of convertLong() it does not make sense to check Date. If it is receiving
Date may be the root cause is something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
