pvary commented on code in PR #15279:
URL: https://github.com/apache/iceberg/pull/15279#discussion_r2828687747
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -93,20 +128,31 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
!overwrite || context.isBounded(),
"Unbounded data stream doesn't support overwrite operation.");
- if (resolvedSchema != null) {
- List<String> equalityColumns =
- resolvedSchema
- .getPrimaryKey()
- .map(UniqueConstraint::getColumns)
- .orElseGet(ImmutableList::of);
+ return (DataStreamSinkProvider)
+ (providerContext, dataStream) -> {
+ if (catalogLoader != null && dynamicRecordGeneratorImpl != null) {
+ return createDynamicIcebergSink(dataStream);
+ }
+
+ // Existing logic for regular sink
+ if (resolvedSchema != null) {
+ ResolvedSchema physicalColumnsOnlySchema =
+ ResolvedSchema.of(
+ resolvedSchema.getColumns().stream()
+ .filter(Column::isPhysical)
+ .collect(Collectors.toList()));
+
+ List<String> equalityColumns =
+ physicalColumnsOnlySchema
+ .getPrimaryKey()
+ .map(UniqueConstraint::getColumns)
+ .orElseGet(ImmutableList::of);
- return (DataStreamSinkProvider)
- (providerContext, dataStream) -> {
if (Boolean.TRUE.equals(
readableConfig.get(FlinkConfigOptions.TABLE_EXEC_ICEBERG_USE_V2_SINK))) {
return IcebergSink.forRowData(dataStream)
Review Comment:
Could we just create a method of all of the sink creation, like
```
return createDynamicIcebergSink(dataStream);
return legacySink(dataStream, resolvedSchema, equalityColumns);
return icebergSink(dataStream, resolvedSchema, equalityColumns);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
