kevinjqliu commented on code in PR #15124: URL: https://github.com/apache/iceberg/pull/15124#discussion_r2809886412
########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## @@ -0,0 +1,121 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Flink Quickstart with Apache Iceberg +# Usage: docker compose up -d +# Connect to SQL client: docker exec -it jobmanager ./bin/sql-client.sh + +volumes: + data: {} + +services: + # MinIO for S3-compatible object storage + minio: + image: minio/minio + hostname: minio + environment: + MINIO_ROOT_USER: admin + MINIO_ROOT_PASSWORD: password + ports: + - "9000:9000" + - "9001:9001" + volumes: + - data:/data + command: server /data --console-address ":9001" + healthcheck: + test: ["CMD", "mc", "ready", "local"] + interval: 5s + timeout: 5s + retries: 5 + + # Create the warehouse bucket + create-bucket: + image: minio/mc + depends_on: + minio: + condition: service_healthy + entrypoint: > + /bin/sh -c " + mc alias set minio http://minio:9000 admin password; + mc mb minio/warehouse --ignore-existing; + exit 0; + " + + # Iceberg REST Catalog + iceberg-rest: + image: apache/iceberg-rest-fixture + hostname: iceberg-rest + depends_on: + create-bucket: + condition: service_completed_successfully + ports: + - "8181:8181" + environment: + AWS_REGION: us-east-1 + CATALOG_WAREHOUSE: s3://warehouse/ + CATALOG_IO__IMPL: org.apache.iceberg.aws.s3.S3FileIO + CATALOG_S3_ENDPOINT: http://minio:9000 + CATALOG_S3_PATH__STYLE__ACCESS: "true" + CATALOG_S3_ACCESS__KEY__ID: admin + CATALOG_S3_SECRET__ACCESS__KEY: password + + # Flink JobManager + jobmanager: + build: ../../docker/iceberg-flink-quickstart + hostname: jobmanager + container_name: jobmanager Review Comment: ```suggestion container_name: jobmanager depends_on: - iceberg-rest ``` good to wait for IRC to complete set up ########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## @@ -0,0 +1,121 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Flink Quickstart with Apache Iceberg +# Usage: docker compose up -d +# Connect to SQL client: docker exec -it jobmanager ./bin/sql-client.sh + +volumes: + data: {} + +services: + # MinIO for S3-compatible object storage + minio: + image: minio/minio + hostname: minio + environment: + MINIO_ROOT_USER: admin + MINIO_ROOT_PASSWORD: password + ports: + - "9000:9000" + - "9001:9001" + volumes: + - data:/data + command: server /data --console-address ":9001" + healthcheck: + test: ["CMD", "mc", "ready", "local"] + interval: 5s + timeout: 5s + retries: 5 + + # Create the warehouse bucket + create-bucket: + image: minio/mc + depends_on: + minio: + condition: service_healthy + entrypoint: > + /bin/sh -c " + mc alias set minio http://minio:9000 admin password; + mc mb minio/warehouse --ignore-existing; + exit 0; + " + + # Iceberg REST Catalog + iceberg-rest: + image: apache/iceberg-rest-fixture + hostname: iceberg-rest + depends_on: + create-bucket: + condition: service_completed_successfully + ports: + - "8181:8181" + environment: + AWS_REGION: us-east-1 + CATALOG_WAREHOUSE: s3://warehouse/ + CATALOG_IO__IMPL: org.apache.iceberg.aws.s3.S3FileIO + CATALOG_S3_ENDPOINT: http://minio:9000 + CATALOG_S3_PATH__STYLE__ACCESS: "true" + CATALOG_S3_ACCESS__KEY__ID: admin + CATALOG_S3_SECRET__ACCESS__KEY: password + + # Flink JobManager + jobmanager: + build: ../../docker/iceberg-flink-quickstart Review Comment: ```suggestion build: . ``` Dockerfile is now in this folder ########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## @@ -0,0 +1,121 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Flink Quickstart with Apache Iceberg +# Usage: docker compose up -d +# Connect to SQL client: docker exec -it jobmanager ./bin/sql-client.sh + +volumes: + data: {} + Review Comment: ```suggestion ``` dont think we need storage to persist across container restarts ########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## @@ -0,0 +1,121 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Flink Quickstart with Apache Iceberg +# Usage: docker compose up -d +# Connect to SQL client: docker exec -it jobmanager ./bin/sql-client.sh + +volumes: + data: {} + +services: + # MinIO for S3-compatible object storage + minio: + image: minio/minio + hostname: minio + environment: + MINIO_ROOT_USER: admin + MINIO_ROOT_PASSWORD: password + ports: + - "9000:9000" + - "9001:9001" + volumes: + - data:/data Review Comment: ```suggestion ``` same as above, dont need persistent storage ########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## Review Comment: nit: wdyt about reordering the services? since this is a flink quickstart, we can start with flink, then irc, then minio ########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## @@ -0,0 +1,121 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Flink Quickstart with Apache Iceberg +# Usage: docker compose up -d +# Connect to SQL client: docker exec -it jobmanager ./bin/sql-client.sh Review Comment: ```suggestion # Flink Quickstart with Apache Iceberg # # Usage: # docker compose -f docker/iceberg-flink-quickstart/docker-compose.yml up -d # # Connect to SQL client: # docker exec -it jobmanager ./bin/sql-client.sh ``` ########## docker/iceberg-flink-quickstart/docker-compose.yml: ########## @@ -0,0 +1,121 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Flink Quickstart with Apache Iceberg +# Usage: docker compose up -d +# Connect to SQL client: docker exec -it jobmanager ./bin/sql-client.sh + +volumes: + data: {} + +services: + # MinIO for S3-compatible object storage + minio: + image: minio/minio + hostname: minio + environment: + MINIO_ROOT_USER: admin + MINIO_ROOT_PASSWORD: password + ports: + - "9000:9000" + - "9001:9001" + volumes: + - data:/data + command: server /data --console-address ":9001" + healthcheck: + test: ["CMD", "mc", "ready", "local"] + interval: 5s + timeout: 5s + retries: 5 + + # Create the warehouse bucket + create-bucket: + image: minio/mc + depends_on: + minio: + condition: service_healthy + entrypoint: > + /bin/sh -c " + mc alias set minio http://minio:9000 admin password; + mc mb minio/warehouse --ignore-existing; + exit 0; + " + + # Iceberg REST Catalog + iceberg-rest: + image: apache/iceberg-rest-fixture + hostname: iceberg-rest + depends_on: + create-bucket: + condition: service_completed_successfully + ports: + - "8181:8181" + environment: + AWS_REGION: us-east-1 + CATALOG_WAREHOUSE: s3://warehouse/ + CATALOG_IO__IMPL: org.apache.iceberg.aws.s3.S3FileIO + CATALOG_S3_ENDPOINT: http://minio:9000 + CATALOG_S3_PATH__STYLE__ACCESS: "true" + CATALOG_S3_ACCESS__KEY__ID: admin + CATALOG_S3_SECRET__ACCESS__KEY: password + + # Flink JobManager + jobmanager: + build: ../../docker/iceberg-flink-quickstart + hostname: jobmanager + container_name: jobmanager + ports: + - "8081:8081" + command: jobmanager + healthcheck: + test: ["CMD", "curl", "-f", "http://localhost:8081/overview";] + start_period: 30s + interval: 5s + timeout: 3s + retries: 5 + environment: + FLINK_PROPERTIES: | + jobmanager.rpc.address: jobmanager + taskmanager.numberOfTaskSlots: 2 + parallelism.default: 2 + AWS_REGION: us-east-1 + AWS_ACCESS_KEY_ID: admin + AWS_SECRET_ACCESS_KEY: password + S3_ENDPOINT: http://minio:9000 + S3_PATH_STYLE_ACCESS: "true" + + # Flink TaskManager + taskmanager: + build: ../../docker/iceberg-flink-quickstart Review Comment: ```suggestion build: . ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
