zhjwpku commented on code in PR #542: URL: https://github.com/apache/iceberg-cpp/pull/542#discussion_r2803975284
########## src/iceberg/transaction.h: ########## @@ -129,14 +141,15 @@ class ICEBERG_EXPORT Transaction : public std::enable_shared_from_this<Transacti private: friend class PendingUpdate; + friend class SnapshotManager; Review Comment: Yeah, this is necessary, because `NewSetSnapshot` and `NewUpdateSnapshotReference` have been moved to private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
