stevenzwu commented on code in PR #11041:
URL: https://github.com/apache/iceberg/pull/11041#discussion_r2801517081


##########
format/view-spec.md:
##########
@@ -82,9 +97,12 @@ Each version in `versions` is a struct with the following 
fields:
 | _required_  | `representations`   | A list of 
[representations](#representations) for the view definition         |
 | _optional_  | `default-catalog`   | Catalog name to use when a reference in 
the SELECT does not contain a catalog |
 | _required_  | `default-namespace` | Namespace to use when a reference in the 
SELECT is a single identifier        |
+| _optional_  | `storage-table`     | A [storage table 
identifier](#storage-table-identifier) of the storage table |

Review Comment:
   In my mind, it seems natural for the `CREATE MATERIALIZED VIEW` DDL to 
create the view and storage table objects together in the catalog. Just that 
initially, the storage table will be empty until refresh kicks in. One benefit 
of this choice is to apply the storage configs (like partition, sort order 
etc.) from DDL to the storage table. Otherwise, those storage configs would 
need to be persisted to the view object when executing the DDL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to