stevenzwu commented on code in PR #15255:
URL: https://github.com/apache/iceberg/pull/15255#discussion_r2797046623
##########
orc/src/main/java/org/apache/iceberg/orc/ORC.java:
##########
@@ -775,12 +780,20 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
return this;
}
+ ReadBuilder constantFieldIds(Set<Integer> newConstantFieldIds) {
+ this.constantFieldIds = newConstantFieldIds;
+ return this;
+ }
+
public <D> CloseableIterable<D> build() {
Preconditions.checkNotNull(schema, "Schema is required");
return new OrcIterable<>(
file,
conf,
- schema,
+ // This is a behavioral change. Previously there were an error if
metadata columns were
Review Comment:
Also we should probably remove the `This is a behavioral change` from the
code comment. It should be just a PR comment. code comment should just explain
why we are stripping away the constant and metadata fields from the schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
