askalt commented on PR #2123: URL: https://github.com/apache/iceberg-rust/pull/2123#issuecomment-3882523955
> Thanks for the example! But I'm still a bit confused about why you need to pass `schema` into `IcebergTableProvider`. The only benefit I'm seeing here is that we can avoid one conversion from iceberg schema to arrow schema. Maybe I'm overlooking something? > > Imo, the schema should come from iceberg table metadata otherwise there may be unexpected behaviors. Yes, it seems we could avoid explicit schema passing. Reworked to just export the constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
