ggershinsky commented on code in PR #14621:
URL: https://github.com/apache/iceberg/pull/14621#discussion_r2787630310


##########
docs/docs/encryption.md:
##########
@@ -0,0 +1,153 @@
+---
+title: "Encryption"
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Encryption
+
+Iceberg table encryption protects confidentiality and integrity of table data 
in an untrusted storage. The `data`, `delete`, `manifest` and `manifest list` 
files are encrypted and tamper-proofed before being sent to the storage backend.
+
+The `metadata.json` file does not contain data or stats, and is therefore not 
encrypted.

Review Comment:
   Thanks again @singhpk234, can you please clarify a few points
   1. Is the following true? - partition summary is not a part of the snapshot 
summary in the Iceberg spec 
https://iceberg.apache.org/spec/#optional-snapshot-summary-fields ; but in the 
implementation, it is added sometimes to the snapshots and can contain data 
stats.
   2. If yes, when the partition summaries are enabled, and when do they have 
stats? Is any of this under the writing user control?
   3. Can you give an example of such a usecase (that writes stats to the 
metadata.json)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to