lishuxu commented on code in PR #544:
URL: https://github.com/apache/iceberg-cpp/pull/544#discussion_r2786571286
##########
src/iceberg/catalog/rest/http_client.h:
##########
@@ -78,38 +78,39 @@ class ICEBERG_REST_EXPORT HttpClient {
HttpClient(HttpClient&&) = delete;
HttpClient& operator=(HttpClient&&) = delete;
+ /// \brief Set the authentication session
+ void SetAuthSession(auth::AuthSession* session);
Review Comment:
Makes sense. Removed SetAuthSession and changed all HTTP methods to accept
AuthSession& as a required reference parameter. When authentication is not
enabled, NoopAuthManager produces a noop session via
AuthSession::MakeDefault({})
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
