Copilot commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2785374790
##########
baseline.gradle:
##########
@@ -36,7 +36,6 @@ subprojects {
// Thus we concede to applying all of the Baseline plugins individually on
all the projects we are
// ready to enforce linting on.
Review Comment:
This PR removes application of `org.inferred.processors` and
`com.palantir.baseline-exact-dependencies`. Since that changes build
enforcement/behavior (annotation processor handling and dependency
verification), add a short comment here explaining why they were removed for
the Gradle 9.3.1 upgrade (e.g., incompatibility/removal), and whether there is
a replacement mechanism or intentional relaxation.
```suggestion
// ready to enforce linting on.
// Note: as part of the Gradle 9.3.1 upgrade we stopped applying the
org.inferred.processors and
// com.palantir.baseline-exact-dependencies plugins because they are no
longer compatible / supported.
// We now rely on Gradle's built-in annotation processor handling and
dependency verification, which
// is an intentional relaxation compared to the previous Baseline
enforcement.
```
##########
deploy.gradle:
##########
@@ -33,13 +33,13 @@ subprojects {
task sourceJar(type: Jar, dependsOn: classes) {
archiveClassifier.set('sources')
from sourceSets.main.allSource
- group 'build'
+ group = 'build'
}
task javadocJar(type: Jar, dependsOn: javadoc) {
archiveClassifier.set('javadoc')
from javadoc.destinationDir
Review Comment:
This references `javadoc.destinationDir`, which is deprecated/likely removed
in newer Gradle versions. Use `javadoc.destinationDirectory` (and convert to a
`File` only if needed, e.g., via `.get().asFile`) to keep the `javadocJar` task
compatible with Gradle 9.x.
```suggestion
from javadoc.destinationDirectory.get().asFile
```
##########
tasks.gradle:
##########
@@ -22,7 +22,7 @@ task aggregateJavadoc(type: Javadoc) {
def javadocTasks = subprojects.findAll { it.name != 'iceberg-bom' }.javadoc
dependsOn javadocTasks
source javadocTasks.source
- destinationDir
project.rootProject.file("site/docs/javadoc/${getJavadocVersion()}")
+ destinationDir =
project.rootProject.file("site/docs/javadoc/${getJavadocVersion()}")
Review Comment:
`destinationDir` on `Javadoc` has been deprecated for several Gradle
versions and may be removed/unsupported in Gradle 9+. To avoid build breaks on
Gradle 9.x, prefer the `destinationDirectory` property (a `DirectoryProperty`)
and set it via `destinationDirectory.set(...)` (or `destinationDirectory = ...`
if supported) instead of using `destinationDir`.
```suggestion
destinationDirectory.set(project.rootProject.file("site/docs/javadoc/${getJavadocVersion()}"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
