gaborkaszab commented on PR #15057: URL: https://github.com/apache/iceberg/pull/15057#issuecomment-3871142652
> @gaborkaszab Could we add a small regression test asserting ETag(loadTable?snapshots=all) != ETag(loadTable?snapshots=refs) for the same table/metadataLocation? Thanks for taking a look, @huaxingao ! We have a test in TestETagProvider to see that different params result different ETags. I added an E2E test too to more coverage. WDYT? One thing I notice with this approach in overall. Let's say SnapshotMode.ALL gives the same result as SnapshotMode.REFS. With this design we get different ETags for such queries even though the results are same. I don't think this is an issue we have to address, just raising attention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
