nastra commented on code in PR #14941:
URL: https://github.com/apache/iceberg/pull/14941#discussion_r2781038985
##########
build.gradle:
##########
@@ -1230,3 +1233,19 @@ project(':iceberg-bom') {
// Needed to get the "faked" Scala artifacts into the bom
javaPlatform { allowDependencies() }
}
+
+subprojects {
+ if (project.name.startsWith('iceberg-spark') ||
+ project.name.startsWith('iceberg-flink') ||
+ project.name.startsWith('iceberg-delta-lake') ||
+ project.name.startsWith('iceberg-kafka-connect')) {
Review Comment:
I agree with @singhpk234 here and I think we should override the dependency
for all iceberg modules. That way we can't accidentally introduce it anywhere
else. Also the changes in L372 for the `iceberg-core` module won't be necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
