rcjverhoef commented on code in PR #15122: URL: https://github.com/apache/iceberg/pull/15122#discussion_r2780338456
########## docs/docs/aws.md: ########## @@ -659,6 +659,25 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 Dual-stack, please refer [Using dual-stack endpoints from the AWS CLI and the AWS SDKs](https://docs.aws.amazon.com/AmazonS3/latest/userguide/dual-stack-endpoints.html#dual-stack-endpoints-cli) +### S3 Metrics Publisher + +`S3FileIO` supports configuring a custom [MetricPublisher](https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/metrics/MetricPublisher.html) to capture metrics emitted by the AWS SDK for S3 operations. Note that this is not supported when using the [S3 CRT client](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/crt-based-s3-client.html) (`s3.crt.enabled=true`). + +To enable, set `s3.metrics-publisher-impl` to a class implementing `MetricPublisher`. The class must provide either a static `create(Map<String, String>)` factory method or a no-arg constructor. + +| Property | Default | Description | +| -------------------------- | ------- | --------------------------------------------------------------------------- | +| s3.metrics-publisher-impl | null | Fully qualified class name of a `MetricPublisher` implementation | + +For example, to use a custom metrics publisher with Spark 3.5: Review Comment: I'll rename -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
