geruh opened a new pull request, #3006:
URL: https://github.com/apache/iceberg-python/pull/3006

   # Rationale for this change
   
   Fixes a test failure that hits anyone with PyIceberg already configured.
   
   The test uses `load_catalog("default", type="in-memory")`, which merges your 
dev environment config with the test parameters. If you have a `default` 
catalog defined in `~/.pyiceberg.yaml` with something like uri: 
https://best-rest-catalog.com, the merge produces `{"uri": 
"https://best-rest-catalog.com";, "type": "in-memory"}`. SQLAlchemy sees that 
https:// URI and tries to load it as a database dialect, which fails wuth:
   
   ```
   sqlalchemy.exc.NoSuchModuleError: Can't load plugin: 
sqlalchemy.dialects:https
   ```
   
   Therefore, this PR uses InMemoryCatalog directly instead of going through 
`load_catalog()`.
   
   ## Are these changes tested?
   
   Yes. I created a conflicting ~/.pyiceberg.yaml with a default catalog 
pointing to an HTTPS REST endpoint, confirmed the old code fails, and verified 
the fix bypasses the config merge and works.
   
   ## Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to