kevinjqliu opened a new pull request, #2989:
URL: https://github.com/apache/iceberg-python/pull/2989
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
The `test-coverage` target was failing with "No data to combine" because the
`COVERAGE=1` variable wasn't being propagated to prerequisite test targets.
Make's target-specific variable syntax (`test-coverage: COVERAGE=1`) only
sets the variable for that specific target, not for its prerequisites when they
execute as separate Make invocations.
Found this out when verifying release, which is the only place we run `make
test-coverage`. CI runs `make coverage-report`
## Are these changes tested?
Ran `make test-coverage` before and after
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
