davseitsev commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2746860438
##########
open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java:
##########
@@ -97,4 +97,9 @@ protected boolean supportsNamesWithDot() {
return PropertyUtil.propertyAsBoolean(
restCatalog.properties(),
RESTCompatibilityKitSuite.RCK_SUPPORTS_NAMES_WITH_DOT, false);
}
+
+ @Override
+ protected boolean supportsUniqueTableLocation() {
+ return false;
Review Comment:
@nastra I enabled new tests for `TestRESTCatalog` and set
`UNIQUE_TABLE_LOCATION` for `backendCatalog`, please take a look.
There are two other places where I can't set `UNIQUE_TABLE_LOCATION` only
for new tests:
-
[TestBaseWithCatalog.java#REST_SERVER_EXTENSION](https://github.com/apache/iceberg/blob/3149892438ec7d4114fc2d79e970188dd3c90a44/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java#L61-L72)
- RESTServerExtension is not configurable per test, so I can't run my Spark
tests on REST Catalog.
-
[RESTCompatibilityKitCatalogTests.java#RESTServerExtension](https://github.com/apache/iceberg/blob/b72b7c1f752081e7ad8be1d40ccdea00a4fd5777/open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java#L33)
- the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
