nastra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2744894517
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3ObjectMapper.java:
##########
@@ -21,25 +21,16 @@
import com.fasterxml.jackson.annotation.JsonAutoDetect;
import com.fasterxml.jackson.annotation.PropertyAccessor;
import com.fasterxml.jackson.core.JsonFactory;
-import com.fasterxml.jackson.core.JsonGenerator;
-import com.fasterxml.jackson.core.JsonParser;
-import com.fasterxml.jackson.databind.DeserializationContext;
import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.JsonDeserializer;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.JsonSerializer;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
-import com.fasterxml.jackson.databind.SerializerProvider;
-import com.fasterxml.jackson.databind.module.SimpleModule;
-import java.io.IOException;
-import org.apache.iceberg.rest.RESTSerializers.ErrorResponseDeserializer;
-import org.apache.iceberg.rest.RESTSerializers.ErrorResponseSerializer;
-import org.apache.iceberg.rest.RESTSerializers.OAuthTokenResponseDeserializer;
-import org.apache.iceberg.rest.RESTSerializers.OAuthTokenResponseSerializer;
-import org.apache.iceberg.rest.responses.ErrorResponse;
-import org.apache.iceberg.rest.responses.OAuthTokenResponse;
+import org.apache.iceberg.rest.RESTSerializers;
+/**
+ * @deprecated since 1.11.0, will be removed in 1.12.0; the serializers for S3
signing are now
+ * registered in {@link RESTSerializers}.
+ */
+@Deprecated
Review Comment:
this class I would probably just deprecate and not switch to using
`RESTSerializers.registerAll(MAPPER)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
