rymurr commented on code in PR #14966:
URL: https://github.com/apache/iceberg/pull/14966#discussion_r2740757779


##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -109,6 +130,22 @@ public DataLakeFileSystemClient client(String path) {
 
   @VisibleForTesting
   DataLakeFileSystemClient client(ADLSLocation location) {
+    if (clientCache == null) {

Review Comment:
   I think this can be created in teh constructor or on line 63 (then it 
doesn't need to be volatile either). Then we don't need any locking



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to