viirya opened a new pull request, #2082:
URL: https://github.com/apache/iceberg-rust/pull/2082
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
This commit adds comprehensive support for pushing down Boolean predicates
to the Iceberg table scan layer, improving query performance by filtering data
at the storage level.
Changes:
- Enhanced expr_to_predicate.rs to handle boolean column expressions:
* Bare boolean columns in filters (e.g., WHERE is_active) are converted to
column = true predicates
* NOT of boolean columns (e.g., WHERE NOT is_active) are converted to
column = false predicates
* Added Boolean scalar value to Datum conversion
- Added comprehensive sqllogictest (boolean_predicate_pushdown.slt) with:
* Tests for is_active = true/false with EXPLAIN verification
* Tests for is_active != true with EXPLAIN verification
* Tests for combined predicates (AND/OR)
* Tests for IS NULL/IS NOT NULL on boolean columns
- Created test_boolean_table in engine setup for testing
- Updated test schedule and show_tables baseline
All tests verify that predicates are successfully pushed down to
IcebergTableScan, not just executed in FilterExec.
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
