gabeiglio commented on code in PR #2410:
URL: https://github.com/apache/iceberg-python/pull/2410#discussion_r2732018995
##########
pyiceberg/partitioning.py:
##########
@@ -249,6 +250,37 @@ def partition_to_path(self, data: Record, schema: Schema)
-> str:
path = "/".join([field_str + "=" + value_str for field_str, value_str
in zip(field_strs, value_strs, strict=True)])
return path
+ def check_compatible(self, schema: Schema, allow_missing_fields: bool =
False) -> None:
Review Comment:
check_compatible in Java its only used with `allowMissingField=true`
([ctx](https://github.com/apache/iceberg/pull/14089)) when reading metadata
tables. Since here we only use this check (for now) at write path only, I think
we could remove this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
