Copilot commented on code in PR #15145: URL: https://github.com/apache/iceberg/pull/15145#discussion_r2728970316
########## dev/.rat-excludes: ########## @@ -5,31 +5,31 @@ iceberg-build.properties .java-version books.json new-books.json -build +**/build/** .gitignore -.git -.gradle -.idea -.rat-excludes -LICENSE -NOTICE -revapi.yml +.git/** +.gradle/** +.idea/** +dev/.rat-excludes +**/LICENSE +**/NOTICE +**/revapi.yml gradlew -examples/* -gradle/* -.*\.sql -.*\.iml -.*\.iws -.*\.html -.*\.css -.*\.js -.*\.svg -.*\.lock -.*\.json -.*\.bin -.*\.prefs -package-list +examples/** +gradle/** +**/*.sql +**/*.iml +**/*.iws +**/*.html +**/*.css +**/*.js +**/*.svg +**/*.lock +**/*.json +**/*.bin +**/*.prefs +**/package-list Review Comment: These extension-based exclusions (e.g., `**/*.sql`, `**/*.html`, `**/*.json`, `**/*.bin`, `**/package-list`) also use `**` glob syntax, but Apache RAT's exclude file expects Java regex patterns, so these will not behave as intended and many files that were previously excluded (`.*\\.sql`, `.*\\.html`, etc.) will now be scanned. This can introduce unexpected license failures; consider keeping the previous regex-style patterns or updating them to valid regex equivalents that match the same files. ########## dev/.rat-excludes: ########## @@ -5,31 +5,31 @@ iceberg-build.properties .java-version books.json new-books.json -build +**/build/** .gitignore -.git -.gradle -.idea -.rat-excludes -LICENSE -NOTICE -revapi.yml +.git/** +.gradle/** +.idea/** +dev/.rat-excludes +**/LICENSE +**/NOTICE +**/revapi.yml gradlew -examples/* -gradle/* -.*\.sql -.*\.iml -.*\.iws -.*\.html -.*\.css -.*\.js -.*\.svg -.*\.lock -.*\.json -.*\.bin -.*\.prefs -package-list +examples/** +gradle/** +**/*.sql +**/*.iml +**/*.iws +**/*.html +**/*.css +**/*.js +**/*.svg +**/*.lock +**/*.json +**/*.bin +**/*.prefs +**/package-list sitemap.xml -derby.log +**/derby.log .python-version -.*_index.md +**/*_index.md Review Comment: The new patterns `**/derby.log` and `**/*_index.md` appear to assume glob semantics, but if Apache RAT is still interpreting exclusion expressions as regular expressions, these entries will not match the target files. To ensure these files remain excluded, please switch to regex-style patterns consistent with the rest of the project (for example by using `.*` and escaping metacharacters) or verify and document a change in RAT's expected pattern syntax. ########## dev/.rat-excludes: ########## @@ -5,31 +5,31 @@ iceberg-build.properties .java-version books.json new-books.json -build +**/build/** .gitignore -.git -.gradle -.idea -.rat-excludes -LICENSE -NOTICE -revapi.yml +.git/** +.gradle/** +.idea/** +dev/.rat-excludes +**/LICENSE +**/NOTICE +**/revapi.yml Review Comment: In this exclusion file, Apache RAT still expects Java regular expressions, but these updated patterns (e.g., `**/build/**`, `**/LICENSE`, `**/NOTICE`, `**/revapi.yml`) use `**` glob-style wildcards instead of valid regex, so they will not match the intended paths and previously excluded files may start being checked and fail CI. Please convert these to equivalent regexes (for example using `.*` and proper escaping) or otherwise align with RAT's documented pattern syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
