adutra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2728657547
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1249,6 +1249,41 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/sign/{provider}:
Review Comment:
> may be wanna then keep this info in the payload
What do you mean by payload? If you mean in the request body that the signer
sends to the signer endpoint, that would require support for request
properties, cf dev ML thread:
https://lists.apache.org/thread/gz5nm2xzlhzbc2y3sfossgflnkbm6vq5
But yes, that would work. If people think that's a preferable path, I'm fine
with it. (I'm preparing a PR for that as well.)
> how are the location checks happening don't we wanna do prefix match ?
Indeed the signer endpoint needs to do a mapping from HTTP URI to
S3/GCS/ADLS URIs, in order to validate locations. The mapping can be complex
(think: S3 path-style vs virtual-host style, many domains/regions etc.). But it
would be even more complex if the signer doesn't even know the target storage
provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
