WZhuo commented on code in PR #408:
URL: https://github.com/apache/iceberg-cpp/pull/408#discussion_r2684678720
##########
src/iceberg/transaction.cc:
##########
@@ -69,6 +73,16 @@ const TableMetadata* Transaction::base() const { return
metadata_builder_->base(
const TableMetadata& Transaction::current() const { return
metadata_builder_->current(); }
+std::string Transaction::MetadataFileLocation(std::string_view filename) const
{
Review Comment:
It's also used in `TableMetadataUtil::NewTableMetadataFilePath`, I think it
can be a public static method of TableMetadataUtil. Maybe do it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
