010Soham commented on code in PR #2846:
URL: https://github.com/apache/iceberg-python/pull/2846#discussion_r2663928925
##########
pyiceberg/io/fsspec.py:
##########
@@ -121,9 +121,19 @@ def __call__(self, request: "AWSRequest", **_: Any) ->
None:
signer_url = self.properties.get(S3_SIGNER_URI,
self.properties[URI]).rstrip("/") # type: ignore
signer_endpoint = self.properties.get(S3_SIGNER_ENDPOINT,
S3_SIGNER_ENDPOINT_DEFAULT)
- signer_headers = {}
+ signer_headers: dict[str, str] = {}
+
+ auth_header: str | None = None
if token := self.properties.get(TOKEN):
- signer_headers = {"Authorization": f"Bearer {token}"}
Review Comment:
updated the code so that AuthManager now takes precedence over token when
both are set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
