wgtmac commented on code in PR #482:
URL: https://github.com/apache/iceberg-cpp/pull/482#discussion_r2660812503
##########
src/iceberg/catalog/rest/resource_paths.cc:
##########
@@ -46,8 +46,8 @@ Status ResourcePaths::SetBaseUri(const std::string& base_uri)
{
return {};
}
-Result<std::string> ResourcePaths::Config() const {
- return std::format("{}/v1/config", base_uri_);
+Result<std::string> ResourcePaths::Config(const std::string& base_uri) {
Review Comment:
Please rebase this PR since this has been committed already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
