WZhuo commented on code in PR #468:
URL: https://github.com/apache/iceberg-cpp/pull/468#discussion_r2660154504
##########
src/iceberg/test/literal_test.cc:
##########
@@ -546,9 +546,9 @@ INSTANTIATE_TEST_SUITE_P(
.expected_type_id = TypeId::kDecimal,
.expected_string = "0"},
BasicLiteralTestParam{.test_name = "String",
- .literal = Literal::String("hello world"),
+ .literal = Literal::String("hello \" world"),
.expected_type_id = TypeId::kString,
- .expected_string = "\"hello world\""},
+ .expected_string = "\"hello \\\" world\""},
Review Comment:
I think it's somehow like json literal. `true`, `false` for bool type,
`1234` for integer and also json dump for string type, `"hello\"world"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
