amogh-jahagirdar commented on code in PR #1961:
URL: https://github.com/apache/iceberg-rust/pull/1961#discussion_r2659952422
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -781,6 +837,7 @@ impl Catalog for RestCatalog {
/// Check if a table exists in the catalog.
async fn table_exists(&self, table: &TableIdent) -> Result<bool> {
let context = self.context().await?;
+ Endpoint::check_supported(&context.config.endpoints,
Endpoint::v1_table_exists())?;
Review Comment:
Yeah that's why I left this in draft, I wanted to think through more how to
handle this particular case. We have a choice here, either we say that the rust
client needs to work with those older servers so we take the complexity of not
doing this strict check, or we opt for a cleaner solution which has some
stricter assumptions.
I don't think it's too much extra work to handle the compatibility so I'd
probably just address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
