joyhaldar commented on code in PR #14940:
URL: https://github.com/apache/iceberg/pull/14940#discussion_r2654865434
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryTableOperations.java:
##########
@@ -60,9 +63,12 @@ final class BigQueryTableOperations extends
BaseMetastoreTableOperations {
public void doRefresh() {
// Must default to null.
String metadataLocation = null;
+ this.refreshedTable = null;
try {
- metadataLocation =
-
loadMetadataLocationOrThrow(client.load(tableReference).getExternalCatalogTableOptions());
+ Table table = client.load(tableReference);
Review Comment:
> why do we need this local variable?
Thank you for your review Manu. I used the local variable for readability,
but happy to inline if you think it's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
