zhjwpku commented on code in PR #455:
URL: https://github.com/apache/iceberg-cpp/pull/455#discussion_r2653175450
##########
src/iceberg/constants.h:
##########
@@ -19,12 +19,24 @@
#pragma once
+/// \file iceberg/constants.h
+/// This file defines constants used commonly and shared across multiple
+/// source files. It is mostly useful to add constants that are used as
+/// default values in the class definitions in the header files without
+/// including other headers just for the constant definitions.
+
#include <cstdint>
#include <string_view>
namespace iceberg {
constexpr std::string_view kParquetFieldIdKey = "PARQUET:field_id";
constexpr int64_t kInvalidSnapshotId = -1;
+/// \brief Stand-in for the current sequence number that will be assigned when
the commit
+/// is successful. This is replaced when writing a manifest list by the
ManifestFile
+/// wrapper
Review Comment:
nit: wrapper -> adapter, which matches the code better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
