wgtmac commented on code in PR #457:
URL: https://github.com/apache/iceberg-cpp/pull/457#discussion_r2653106480
##########
src/iceberg/CMakeLists.txt:
##########
@@ -103,26 +104,30 @@ set(ICEBERG_SHARED_INSTALL_INTERFACE_LIBS)
list(APPEND
ICEBERG_STATIC_BUILD_INTERFACE_LIBS
+ cpr::cpr
Review Comment:
Got it. According to prior discussions in the community, we should keep
minimal dependencies of `libiceberg`. If the only reason is to escape partition
path, should we implement our own utility function? IIUC, partition name and
value can only use a limited set of characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
