huaxingao commented on code in PR #14943: URL: https://github.com/apache/iceberg/pull/14943#discussion_r2651542566
########## docs/docs/spark-getting-started.md: ########## @@ -83,7 +83,7 @@ Iceberg also adds row-level SQL updates to Spark, [`MERGE INTO`](spark-writes.md ```sql MERGE INTO local.db.target t USING (SELECT * FROM updates) u ON t.id = u.id -WHEN MATCHED THEN UPDATE SET t.count = t.count + u.count +WHEN MATCHED THEN UPDATE SET t.data = u.data Review Comment: To make this truly runnable (and align with `TestRoundTrip`’s TODO about the getting-started doc not being runnable), should we change `local.db.target` → l`ocal.db.table` and define updates before the MERGE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
