WZhuo commented on code in PR #416:
URL: https://github.com/apache/iceberg-cpp/pull/416#discussion_r2650270823
##########
src/iceberg/catalog/memory/in_memory_catalog.cc:
##########
@@ -405,32 +407,68 @@ Result<std::shared_ptr<Table>>
InMemoryCatalog::CreateTable(
const std::string& location,
const std::unordered_map<std::string, std::string>& properties) {
std::unique_lock lock(mutex_);
- return NotImplemented("create table");
+ if (root_namespace_->TableExists(identifier).value_or(false)) {
+ return AlreadyExists("Table already exists: {}", identifier);
+ }
+
+ std::string base_location =
+ location.empty() ? warehouse_location_ + "/" + identifier.ToString() :
location;
+
+ ICEBERG_ASSIGN_OR_RAISE(auto table_metadata, TableMetadata::Make(*schema,
*spec, *order,
+ location,
properties));
+
+ ICEBERG_ASSIGN_OR_RAISE(
+ auto metadata_file_location,
+ TableMetadataUtil::Write(*file_io_, nullptr, "", *table_metadata));
+ ICEBERG_RETURN_UNEXPECTED(
+ root_namespace_->UpdateTableMetadataLocation(identifier,
metadata_file_location));
+ return Table::Make(identifier, std::move(table_metadata),
+ std::move(metadata_file_location), file_io_,
+ std::static_pointer_cast<Catalog>(shared_from_this()));
Review Comment:
Copy from old code, no need cast any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
