masfworld commented on code in PR #14927:
URL: https://github.com/apache/iceberg/pull/14927#discussion_r2646913113
##########
core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java:
##########
@@ -297,7 +297,9 @@ public void accept(ErrorResponse error) {
throw new ServiceUnavailableException("Service unavailable: %s",
error.message());
}
- throw new RESTException("Unable to process: %s", error.message());
+ throw new RESTException(
Review Comment:
But here it's clear because this exception is triggered when the code is
422, which is `Unprocessable Entity`, then the current message for me is enough.
##########
core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java:
##########
@@ -297,7 +297,9 @@ public void accept(ErrorResponse error) {
throw new ServiceUnavailableException("Service unavailable: %s",
error.message());
}
- throw new RESTException("Unable to process: %s", error.message());
+ throw new RESTException(
+ "Unable to process (code: %s, type: %s): %s",
+ error.code(), error.type() != null ? error.type() : "unknown",
error.message());
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
