CTTY commented on code in PR #1928:
URL: https://github.com/apache/iceberg-rust/pull/1928#discussion_r2646557637
##########
crates/iceberg/src/spec/schema/mod.rs:
##########
@@ -127,6 +127,22 @@ impl SchemaBuilder {
/// Builds the schema.
pub fn build(self) -> Result<Schema> {
+ // If field IDs need to be reassigned, do it first before validation
+ if let Some(start_from) = self.reassign_field_ids_from {
Review Comment:
This is a good point!
My original intention was to avoid building id-to-field map again when we
are trying to reassign field ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
