shangxinli commented on code in PR #426:
URL: https://github.com/apache/iceberg-cpp/pull/426#discussion_r2645955497
##########
src/iceberg/transaction.cc:
##########
@@ -68,7 +68,12 @@ Status
Transaction::Apply(std::vector<std::unique_ptr<TableUpdate>> updates) {
last_update_committed_ = true;
Review Comment:
Yeah, it seem in java the flag hasLastOpCommitted (the equivalent flag)
tracks whether PendingUpdate.commit() was called, not whether
Transaction.commitTransaction()
succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
