kevinjqliu commented on code in PR #2842: URL: https://github.com/apache/iceberg-python/pull/2842#discussion_r2635697097
########## pyiceberg/catalog/rest/__init__.py: ########## @@ -130,6 +132,7 @@ class IdentifierKind(Enum): SNAPSHOT_LOADING_MODE = "snapshot-loading-mode" AUTH = "auth" CUSTOM = "custom" +REST_SCAN_PLANNING_ENABLED = "rest-scan-planning-enabled" Review Comment: i dug into the use of `rest-scan-planning-enabled`, its actually not a catalog server config. RESTSessionCatalog is the catalog client, and `rest-scan-planning-enabled` is used along with the checking whether the specific scan planning endpoint is advertised by the server. https://github.com/apache/iceberg/blob/05998edb8808ae21739072cca17b621925a2081a/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L275-L279 https://github.com/apache/iceberg/blob/05998edb8808ae21739072cca17b621925a2081a/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
