huaxingao commented on code in PR #14886:
URL: https://github.com/apache/iceberg/pull/14886#discussion_r2633165682


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##########
@@ -300,7 +300,10 @@ private DeleteOrphanFiles.Result 
deleteFiles(Dataset<String> orphanFileDS) {
 
     LOG.info("Deleted {} orphan files", filesCount);
 
-    return 
ImmutableDeleteOrphanFiles.Result.builder().orphanFileLocations(orphanFileList).build();
+    return ImmutableDeleteOrphanFiles.Result.builder()
+        .orphanFileLocations(orphanFileList)
+        .deletedOrphanFilesCount(filesCount)

Review Comment:
   `filesCount` is the total number of orphan file paths processed (i.e., 
attempted deletes) across all fileGroups, but it’s not guaranteed to mean 
“successfully deleted” (because deletes can fail).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to