gaborkaszab commented on code in PR #14869:
URL: https://github.com/apache/iceberg/pull/14869#discussion_r2627792966
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1832,6 +1832,60 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/register-view:
+ parameters:
+ - $ref: '#/components/parameters/prefix'
+ - $ref: '#/components/parameters/namespace'
+
+ post:
+ tags:
+ - Catalog API
+ summary: Register a view in the catalog
Review Comment:
This is the summary of registerTable `Register a table in the given
namespace using given metadata file location`
I think we should be in line with this.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1832,6 +1832,60 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/register-view:
+ parameters:
+ - $ref: '#/components/parameters/prefix'
+ - $ref: '#/components/parameters/namespace'
+
+ post:
+ tags:
+ - Catalog API
+ summary: Register a view in the catalog
+ parameters:
+ - $ref: '#/components/parameters/idempotency-key'
+ description:
+ Register a view in the given namespace using given metadata file
location.
Review Comment:
"Register a view using given metadata file location." to be in line with
registerTable?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3687,6 +3741,17 @@ components:
additionalProperties:
type: string
+ RegisterViewRequest:
+ type: object
+ required:
+ - name
+ - metadata-location
+ properties:
+ name:
+ type: string
+ metadata-location:
+ type: string
+
Review Comment:
`RegisterTableRequest` also has an `overwrite` property. Do you plan to add
that too to have a full functionality match with table registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
